Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: delete "moduleResolution": "bundler" from tsconfig and jsconfig #12163

Closed
wants to merge 2 commits into from
Closed

chore: delete "moduleResolution": "bundler" from tsconfig and jsconfig #12163

wants to merge 2 commits into from
+2 −4

Conversation

huseeiin
Copy link
Contributor

Delete "moduleResolution": "bundler" from tsconfig and jsconfig as its already in the tsconfig located at "./.svelte-kit/tsconfig.json"

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [✅ ] This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@huseeiin
Update jsconfig.json
5e12399 
"moduleResolution": "bundler" is already in "extends": "./.svelte-kit/tsconfig.json"
@huseeiin
Update tsconfig.json
dc81574 
"moduleResolution": "bundler" is already in "extends": "./.svelte-kit/tsconfig.json"
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2024

⚠️ No Changeset found

Latest commit: dc81574

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eltigerchino eltigerchino changed the title Delete "moduleResolution": "bundler" from tsconfig and jsconfig chore: delete "moduleResolution": "bundler" from tsconfig and jsconfig May 16, 2024
@vercel vercel bot temporarily deployed to Preview – kit-default-template May 16, 2024 16:17 Inactive
@benmccann benmccann requested a review from dummdidumm May 31, 2024 12:57
@dummdidumm
Copy link
Member

Why remove it? I don't think we should do that.

@eltigerchino
Copy link
Member

I was also thinking of removing it but it’s probably better to not remove it because the generated config only exists after the user runs vite dev, etc.

@dummdidumm
Copy link
Member

Oh right it's part of the generated config by now. Mhm..

@dominikg
Copy link
Member

dominikg commented Jun 2, 2024

i actually wonder if we should encourage commiting the generated config instead of ignoring it.
Remembering to run sync when switching branches is a bit of a pain.

@benmccann benmccann mentioned this pull request Jun 18, 2024
Open
@benmccann
Copy link
Member

I actually wonder if we want to go the reverse direction and set NodeNext in the generated config and then have all apps set bundler. It can be very disruptive to the ecosystem when libraries don't set NodeNext. There's not a lot of harm if an app does that except for annoyance at extra work, but things don't break in the same way that they do if a library sets bundler then potentially affecting all of its dependencies.

E.g. check out the Threlte instructions at https://threlte.xyz/docs/learn/getting-started/installation which have a needless step in their setup instructions because they're missing the moduleResolution that we ship by default for libraries (threlte/threlte#985):

Screenshot from 2024-06-18 15-39-05

@benmccann
Copy link
Member

I'm going to go ahead and close this since the templates have moved to https://github.com/sveltejs/cli

@benmccann benmccann closed this Nov 20, 2024
@benmccann benmccann mentioned this pull request Nov 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm Awaiting requested review from dummdidumm

Assignees
No one assigned
Labels
pkg:create-svelte
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@huseeiin @dummdidumm @eltigerchino @dominikg @benmccann